You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Personally I'd prefer protected friendship only. Or at least by default. Perhaps make an option to declare a private friend explicitly. I think it would be beneficial to have an explicit distinction between accessible and truly private members. And since inheritance is not a great practice in most cases (i.e. composition over it), having a protected method/property in some systems that extensively use composition could indicate that they are used in some friendship relation. While private stay private.
Personally I'd prefer protected friendship only. Or at least by default. Perhaps make an option to declare a private friend explicitly. I think it would be beneficial to have an explicit distinction between accessible and truly private members. And since inheritance is not a great practice in most cases (i.e. composition over it), having a protected method/property in some systems that extensively use composition could indicate that they are used in some friendship relation. While private stay private.
Not going to do that, the idea is that friends can access private parts
"inheritance is not a great practice in most cases" may be your view, but there is plenty of inheritance in the PHP ecosystem
And nothing is truly private when reflection is always available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.